Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path util for macOS in addition to Linux and Windows #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add path util for macOS in addition to Linux and Windows #1

wants to merge 1 commit into from

Conversation

zhenhuaw-me
Copy link

Also add log print per files when converting.

@kilosonc
Copy link
Owner

Sorry for the delay and thanks for your pr!
I'm not sure what the log is used for, could you explain it for me. If you want to know current status, I recommand to add a progress bar.
Besides, if you want to support for macos, the file suffix should be darwin. However, I suggest just changing suffix linux to unix.
Thanks again! @zhenhuaw-me

@zhenhuaw-me
Copy link
Author

@closetool Renamed as your suggestion. Not familiar with Golang...

For the log, it shows something like this. Thus we know if any files have been converted.

2022/11/10 23:08:21 Converting /Users/zhenhuaw/Music/网易云音乐/追梦人 (《雪山飞狐之塞北宝藏》电影推广曲).ncm
2022/11/10 23:08:21 Converting /Users/zhenhuaw/Music/网易云音乐/无法离地的飞行.ncm
2022/11/10 23:08:21 Written to 追梦人 (《雪山飞狐之塞北宝藏》电影推广曲).flac
2022/11/10 23:08:21 Written to 无法离地的飞行.flac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenhuaw-me @kilosonc